Update SlideNavigationController with helper function - removeAllMenu…#264
Open
foreza wants to merge 1 commit intoaryaxt:masterfrom
foreza:support-menu-cleanup
Open
Update SlideNavigationController with helper function - removeAllMenu…#264foreza wants to merge 1 commit intoaryaxt:masterfrom foreza:support-menu-cleanup
foreza wants to merge 1 commit intoaryaxt:masterfrom
foreza:support-menu-cleanup
Conversation
…FromSuperview An issue a client of mine faced was with loading interstitial ads on top of the root controller. The current library doesn't present a way to clean up the menu from the superview. This function is only invoked when we switch from the left -> right menu, or vice versa. Provided a public method that can be invoked in such circumstances that will clean up either the left or right menu (whichever is active) as well as reset the lastRevealedMenu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An issue a client of mine faced was with loading interstitial ads on top of the root controller.
The current library doesn't present a way to clean up the menu from the superview.
This function is only invoked when we switch from the left -> right menu, or vice versa.
Provided a public method that can be invoked in such circumstances that will clean up either the left or right menu (whichever is active) as well as reset the lastRevealedMenu