Skip to content

Skip EnhancedAttributeValue wrapping in converters transformTo when t… #6707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RanVaknin wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Skip EnhancedAttributeValue wrapping in converters transformTo when t… #6707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ffe5e76
Skip EnhancedAttributeValue wrapping in converters transformTo when t…
Feb 4, 2026
0ff0c04
Add isolated benchmarks for converters
RanVaknin Feb 6, 2026
f14cbbd
Fix benchmark mode
RanVaknin Feb 6, 2026
114a939
Remove unusued benchmark
RanVaknin Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...on/awssdk/enhanced/dynamodb/internal/converter/attribute/ByteArrayAttributeConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public AttributeValue transformFrom(byte[] input) {
@Override
public byte[] transformTo(AttributeValue input) {
if (input.b() != null) {
return EnhancedAttributeValue.fromBytes(input.b()).convert(VISITOR);
return input.b().asByteArray();
}

return EnhancedAttributeValue.fromAttributeValue(input).convert(VISITOR);
Expand Down
5 changes: 4 additions & 1 deletion ...mazon/awssdk/enhanced/dynamodb/internal/converter/attribute/StringAttributeConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,10 @@ public AttributeValue transformFrom(String input) {

@Override
public String transformTo(AttributeValue input) {
return Visitor.toString(input);
if (input.s() != null) {
return input.s();
}
return EnhancedAttributeValue.fromAttributeValue(input).convert(Visitor.INSTANCE);
}

private static final class Visitor extends TypeConvertingVisitor<String> {
Expand Down