-
Notifications
You must be signed in to change notification settings - Fork 978
Add additional checksum algorithms #6742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zoewangg
wants to merge
1
commit into
feature/master/addMoreChecksumAlgos
Choose a base branch
from
zoewang/additionalChecksumAlgos
base: feature/master/addMoreChecksumAlgos
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+785
−118
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76 changes: 76 additions & 0 deletions
76
core/checksums/src/main/java/software/amazon/awssdk/checksums/internal/XxHashChecksum.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| /* | ||
| * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"). | ||
| * You may not use this file except in compliance with the License. | ||
| * A copy of the License is located at | ||
| * | ||
| * http://aws.amazon.com/apache2.0 | ||
| * | ||
| * or in the "license" file accompanying this file. This file is distributed | ||
| * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
| * express or implied. See the License for the specific language governing | ||
| * permissions and limitations under the License. | ||
| */ | ||
|
|
||
| package software.amazon.awssdk.checksums.internal; | ||
|
|
||
| import software.amazon.awssdk.annotations.SdkInternalApi; | ||
| import software.amazon.awssdk.checksums.DefaultChecksumAlgorithm; | ||
| import software.amazon.awssdk.checksums.SdkChecksum; | ||
| import software.amazon.awssdk.checksums.spi.ChecksumAlgorithm; | ||
| import software.amazon.awssdk.crt.checksums.XXHash; | ||
|
|
||
| @SdkInternalApi | ||
| public final class XxHashChecksum implements SdkChecksum { | ||
|
|
||
| private final XXHash xxHash; | ||
|
|
||
| public XxHashChecksum(ChecksumAlgorithm algorithm) { | ||
| if (algorithm == DefaultChecksumAlgorithm.XXHASH64) { | ||
| xxHash = XXHash.newXXHash64(); | ||
| } else if (algorithm == DefaultChecksumAlgorithm.XXHASH3) { | ||
| xxHash = XXHash.newXXHash3_64(); | ||
| } else if (algorithm == DefaultChecksumAlgorithm.XXHASH128) { | ||
| xxHash = XXHash.newXXHash3_128(); | ||
| } else { | ||
| throw new UnsupportedOperationException("Unsupported algorithm: " + algorithm.algorithmId()); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void update(byte[] b) { | ||
| xxHash.update(b); | ||
| } | ||
|
|
||
| @Override | ||
| public byte[] getChecksumBytes() { | ||
| return xxHash.digest(); | ||
| } | ||
|
|
||
|
|
||
| @Override | ||
| public void update(int b) { | ||
| xxHash.update(b); | ||
| } | ||
|
|
||
| @Override | ||
| public void update(byte[] b, int off, int len) { | ||
| xxHash.update(b, off, len); | ||
| } | ||
|
|
||
| @Override | ||
| public void reset() { | ||
| throw new UnsupportedOperationException("mark and reset is not supported"); | ||
| } | ||
|
|
||
| @Override | ||
| public void mark(int readLimit) { | ||
| throw new UnsupportedOperationException("mark and reset is not supported"); | ||
| } | ||
|
|
||
| @Override | ||
| public long getValue() { | ||
| throw new UnsupportedOperationException("Use getChecksumBytes() instead."); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The priority order is pending on perf tests