Py2&3 fixes #14
Open
Py2&3 fixes #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Library: - iteritems() -> items() in get_namespace_prefix_for_url - add encoding='unicode' to etree.tostring() in create_message - close_all_clients() failed on changing its dictionary while iterating over it. Now it read the dict keys to a separate list of aliases and iterates over that to close individual clients Regression test set: - changed extraction of namespace data in TC Namespace trickery ( .keys() and .items() return dict view objects which do not allow indexing)
- iteritems() call -> items() (they return different types of objects in py2 and py3 but both can be iterated over) - renamed custom exception attribute message -> err_msg as in py3 Exceptions no longer have a message attribute by default.
variable names, returning) to make linters happier.
call_operation. Add a sample xml file for testing purposes.
This makes it explicitly a new style class in py2 and property tests no longer fail in python 2.7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch includes changes that should enable zeeplibrary to work with both python 2.7 and python 3.
There were not many actual changes required to make the library work with python 3. The pull request branch does, however, contain many commits and some additional changes. I've