Merged
Conversation
Collaborator
✅ Heimdall Review Status
|
tobidae-cb
approved these changes
Oct 28, 2025
tobidae-cb
pushed a commit
that referenced
this pull request
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes fetching metadata and test runs on GHA. Previously, we used a relative path, so requesting
output/metadata.jsonwould resolve tohttps://base.github.io/benchmark/output/metadata.jsonwhen requested fromhttps://base.github.io/benchmark.The previous change added a leading
/to the beginning of the path, so it was not resolving the relative path correctly. Now, we ensure the base url has a trailing/and remove the leading/from request URLs so the static site is portable to any path.Testing