fix: correct demo paths and add missing demos to README#108
Open
giwaov wants to merge 1 commit intobase:masterfrom
Open
fix: correct demo paths and add missing demos to README#108giwaov wants to merge 1 commit intobase:masterfrom
giwaov wants to merge 1 commit intobase:masterfrom
Conversation
- Fix all minikit/ paths to correct mini-apps/workshops/ paths - Fix mini-app-full-demo path to mini-apps/templates/farcaster-sdk/ - Add 6 missing base-account demos (auto-sub-accounts, privy, rainbow, reown, thirdweb, wagmi templates) - Add mini-apps/templates section (full-demo-minikit, quickstart, vite-mini) - Add mini-app-validation tool - Organize table by category for better readability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
minikit/paths that point to non-existent directories — the actual location ismini-apps/workshops/mini-app-full-demopath tomini-apps/templates/farcaster-sdk/mini-app-full-demo/auto-sub-accounts,base-account-privy-template,base-account-rainbow-template,base-account-reown,base-account-thirdweb-template,base-account-wagmi-templatemini-app-full-demo-minikit,new-mini-app-quickstart,vite-minimini-app-validationtoolDetails
The current README references
minikit/as the path prefix for all MiniKit demos, but this directory doesn't exist. The actual demos are organized under:mini-apps/workshops/— workshop demosmini-apps/templates/— starter templates (farcaster-sdk and minikit variants)mini-apps/mini-app-validation/— validation toolingAdditionally, 6 base-account demos and 4 template demos existed in the repo but were not listed in the README.
Test plan