Replace turbo confirmation dialogs with custom delete modals #1948
+31
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the standard turbo_confirm attribute with a custom dialog modal for a better user experience. - Removes `button_to_delete_card` helper in favor of inline markup. - Implements `keydown.esc->dialog#close:stop` to prevent the Escape key from inadvertently closing selected card.
Applies the custom dialog modal pattern to the board deletion workflow, matching the card deletion updates.
jstarner
changed the title
jstarner
changed the title
Member
jorgemanrubia
left a comment
jorgemanrubia
left a comment
There was a problem hiding this comment.
Nice, thanks @jstarner. I like this change! Will ask for some designers here too
Contributor
|
Lovely work, @jstarner! I'd suggest centering the buttons, but this looks great otherwise. Thanks for taking initiative. |
andyra
requested changes
Dec 5, 2025
Contributor
andyra
left a comment
andyra
left a comment
There was a problem hiding this comment.
I'd suggest centering the buttons via .justify-center
Contributor
Author
Thank you @andyra and appreciate the feedback! Love the work y'all are doing and happy to be able to contribute. I've updated the buttons to be centered and included updated screenshots 🙌 |
Member
jorgemanrubia
left a comment
jorgemanrubia
left a comment
There was a problem hiding this comment.
Thank you so much @jstarner
jorgemanrubia
approved these changes
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the deletion UX for cards and boards by replacing the browser-native
turbo_confirmdialogs with custom, styled modals.Changes
app/views/cards/_delete.html.erbto implement custom delete confirmation modal.app/views/boards/edit/_delete.html.erbto use the same accessible modal pattern.button_to_delete_cardhelper method fromapp/helpers/cards_helper.rb.Before
After
