fizzy-oss Rails Engine option #1958
Closed
+83
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @harisadam, I like this idea! I think we need to streamline a bit more our SaaS setup before tackling this. We have some ergonomics to improve on the dev side (e.g aroun bundler). I would like to tackle that before adding more modes here, but I think this is interesting. CC @flavorjones @kevinmcconnell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be an opinionated PR, but it appears to follow the 37signals approach to setting up the project on your own infrastructure.
Similarly to fizzy-sass, this update also uses a dedicated Gemfile (Gemfile.oss) that resolves a user-specific Rails engine name fizzy-oss (my minimal demo implementation: https://github.com/harisadam/fizzy-oss).
This engine-driven approach provides more flexible customization options for users.
If the team agrees this is the right direction, I’m happy to follow up with documentation in the README.