Merged
Conversation
Collaborator
|
Yeah, it looks like this used when generating documentation web pages, here |
Contributor
Author
|
@myeatman-bdai Does that actually require the pseudo-submodule, though? Won't that command create the directory if missing? |
Contributor
Author
|
(or, if not, we could add a |
Collaborator
|
I don't know much about won't work. |
Contributor
Author
|
Shouldn't spatialmath-python/.github/workflows/sphinx.yml Lines 32 to 33 in 99fd55b mkdir line before those two) make it work?
|
Collaborator
|
oh, you're right. Derp. |
Collaborator
|
Lets just merge this and see if the documentation generation still works. |
Collaborator
|
Per this yet to be merged PR #162, the sphinx automation is broken with or without this small changes, so we're going ahead and merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
gh-pagesdirectory, which appears to have been set up as a submodule, but has no definition in a.gitmodulesfile (as no such file is present). This misconfiguration causes problems addingspatialmath-pythonas a dependency to other projects usinguv. If I'm wrong aboutgh-pagesbeing necessary to keep around (e.g., if it somehow triggers the creation of a Github Page for the project?), then we'll need to find a different solution.