Skip to content

Convert RenderTarget to Component #20917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tychedelia wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Convert RenderTarget to Component #20917

tychedelia wants to merge 13 commits into from
+151 −149

Conversation

@tychedelia
Copy link
Member

@tychedelia tychedelia commented Sep 7, 2025

Objective

#20830 created the possibility that we may want to have render targets that produce a number of outputs, e.g. depth and normals. This is a first step towards something like that (e.g. a RendersTo relation) by converting RenderTarget to be a component. This is also useful for out-of-tree render targets that may want to do something like #[require(RenderTarget::Image)] once BSN lands.

Solution

Make it a component.

@tychedelia tychedelia added C-Feature A new feature, making something new possible A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 7, 2025
@tychedelia tychedelia added this to the 0.18 milestone Sep 7, 2025
ickshonpe
ickshonpe approved these changes Sep 7, 2025
View reviewed changes
Copy link
Contributor

@ickshonpe ickshonpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, all the changes make sense, no problems with any of the examples.

@Zeophlite Zeophlite added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 22, 2025
@janhohenheim janhohenheim added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Dec 4, 2025
@janhohenheim
Copy link
Member

janhohenheim commented Dec 4, 2025

marking as waiting-for-author due to merge conflicts

@tychedelia
Merge branch 'main' into render-target-component
9af8f19 
# Conflicts:
#	crates/bevy_camera/src/camera.rs
#	crates/bevy_ui/src/widget/viewport.rs
@tychedelia tychedelia added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Dec 8, 2025
@alice-i-cecile alice-i-cecile added the M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Dec 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes.

alice-i-cecile
alice-i-cecile requested changes Dec 9, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a quick migration guide, but otherwise looks fine.

@tychedelia tychedelia force-pushed the render-target-component branch from fed495b to 9af8f19 Compare December 14, 2025 04:20
@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2025

Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke!
You can review it at https://pixel-eagle.com/project/B04F67C0-C054-4A6F-92EC-F599FEC2FD1D?filter=PR-20917

If it's expected, please add the M-Deliberate-Rendering-Change label.

If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile Awaiting requested review from alice-i-cecile

2 more reviewers

@Zeophlite Zeophlite Zeophlite approved these changes

@ickshonpe ickshonpe ickshonpe approved these changes

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: No status

Milestone

0.18

Development

Successfully merging this pull request may close these issues.

5 participants

@tychedelia @janhohenheim @Zeophlite @alice-i-cecile @ickshonpe