-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Easy demo recording #21243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easy demo recording #21243
Conversation
|
It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note. Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes. |
ebdbb85 to
895088f
Compare
| translation, | ||
| rotation, | ||
| } => { | ||
| info!("Moved camera at frame {}.", *current_frame); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this log prints whether or not the camera actually moves, so should be a different string (if its meant to convey that the event happened) or moved into the if-let (if its meant to convey the component insertion happened)
| query.0.translation.smooth_nudge( | ||
| &target.translation, | ||
| decay_rate, | ||
| time.delta_secs(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regular time delta_secs will always be 0 when the recording is running I think.
|
recording works, but camera movement only happens after the recording is over. animated_mesh-1765768288043.h264.mp4 |
|
moved the camera movement system to that fixes movements during recording |
|
nice, working now. These two are with CI-driven camera control: animated_mesh-1765795452775.h264.mp4shader_material_screenspace_texture-1765795851787.h264.mp4and this one is with application-drive camera movement in PostUpdate: shader_material_screenspace_texture-1765796030791.h264.mp4 |
ChristopherBiscardi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. CI recording is so coooool.
Objective
Solution
Testing
--features bevy_internal/screenrecording,bevy_ci_testingShowcase
load_gltf-1758980570053.h264.mp4