Skip to content

Solari: More accurate ReSTIR DI resampling #22033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JMS55 wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Solari: More accurate ReSTIR DI resampling #22033

JMS55 wants to merge 12 commits into from
+92 −58

Conversation

@JMS55
Copy link
Contributor

@JMS55 JMS55 commented Dec 5, 2025 •
edited
Loading

  • Adds MIS during reservoir merge which increases emissive light brightness, bringing it a little closer to the pathtraced reference
  • Tests final reservoir visibility for shading, but not for resampling, which greatly improves shadow accuracy compared to the pathtraced reference, at the unfortunate cost of higher noise

@JMS55 JMS55 added A-Rendering Drawing game state to the screen C-Refinement Improves output quality, without fixing a clear bug or adding new functionality. labels Dec 5, 2025
@JMS55 JMS55 added this to the 0.18 milestone Dec 5, 2025
@JMS55 JMS55 changed the title Solari: Improve ReSTIR DI resampling Solari: More accurate ReSTIR DI resampling Dec 5, 2025
@JMS55 JMS55 marked this pull request as ready for review December 8, 2025 01:51
@JMS55 JMS55 requested review from IceSentry, SparkyPotato, atlv24 and tychedelia and removed request for SparkyPotato December 8, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atlv24 atlv24 Awaiting requested review from atlv24

@IceSentry IceSentry Awaiting requested review from IceSentry

@tychedelia tychedelia Awaiting requested review from tychedelia

1 more reviewer

@SparkyPotato SparkyPotato SparkyPotato approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Refinement Improves output quality, without fixing a clear bug or adding new functionality.

Projects

Rendering
Status: No status

Milestone

0.18

Development

Successfully merging this pull request may close these issues.

2 participants

@JMS55 @SparkyPotato