Conversation
snowp
force-pushed
the
update-artifact-api-for-state-snapshots-and-passing-fields-via-intent
branch
from
024d33d to
79b862a
Compare
mattklein123
approved these changes
Feb 23, 2026
| // The metadata associated with the artifact. This is a binary blob that is interpreted by the server | ||
| // based on the type_id. | ||
| bytes metadata = 3; | ||
| reserved 3; |
Contributor
There was a problem hiding this comment.
So this was never used?
Contributor
Author
There was a problem hiding this comment.
Yeah never used, I was planning on using it as something like this but we never implemented it. Reusing the concept of a map of fields seems easier for now
snowp
deleted the
update-artifact-api-for-state-snapshots-and-passing-fields-via-intent
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reworks the
metadatafield on the intent request to match what was previouslystate_metadata. For issue reports this will be the fields that are sent up as part of the reportInclude type_id on the artifact index file - this is necessary in order to maintain the type id now that we're introducing multiple types