Support specification of external user-defined macros#22
Open
dmikushin wants to merge 1 commit intobnoazx005:masterfrom
Open
Support specification of external user-defined macros#22dmikushin wants to merge 1 commit intobnoazx005:masterfrom
dmikushin wants to merge 1 commit intobnoazx005:masterfrom
Conversation
… come from the compiler command line options
bnoazx005
reviewed
May 27, 2024
| Preprocessor() TCPP_NOEXCEPT = delete; | ||
| Preprocessor(const Preprocessor&) TCPP_NOEXCEPT = delete; | ||
| Preprocessor(Lexer& lexer, const TPreprocessorConfigInfo& config) TCPP_NOEXCEPT; | ||
| Preprocessor(Lexer& lexer, const TPreprocessorConfigInfo& config, TSymTable userDefines = {}) TCPP_NOEXCEPT; |
Owner
There was a problem hiding this comment.
Maybe it's better to move userDefines into TPreprocessorConfigInfo type to minimize number of arguments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for external user-defined macros, e.g. those that may come from the compiler command line options when we do
gcc -DFOO=\"bar\".Currently, tcpp assumes all macro definitions are a part of the source code text. However, compilers generally allow specifying extra macros from the command line. Moreover, compilers may implicitly define builtin macros, e.g.
__cplusplus.Therefore, I thought we need a way to provide the tcpp preprocessor with a pre-existing symbol table. It's just as easy as adding a couple of lines of code.
A typical usage for this feature would be a tcpp driver program below. In order to avoid creation of symbols table by hand, we ask tcpp to parse a pretty-printed text of macro definitions. Then this symbols table is retrieved and added back upon constructing the preprocessor for the target source file: