Open
Conversation
method for converting to cartesian coordinates from cylindrical coordinates. Add new struct Coordinates3D, to encapsulate (x,y,z) coordinates.
Add toroidal_angle field to TokamakOptions. Iterate over all coordinate points.
so that there will be a toroidal point at pi/2.
…him to allow FakeMeshFixture to be used with default values for nx, ny, nz
Member
|
Looks like you just need to merge recent |
Contributor
|
Could you mention why do you need this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new method CylindricalCoordinatesToCartesian() on TokamakOptions class, which returns Cartesian coordinates x, y, z (as Field3D objects) calculated from the cylindrical coordinates Rxy and Zxy (Field2D objects) together with nz equally spaced points for the values of the toroidal angle.