initial_profiles: Use FieldFactory singleton#3270
Merged
Conversation
Rather than creating a new FieldFactory, use the singleton object. This allows users to register new generators and use them to intialise variables.
ZedThree
approved these changes
Feb 6, 2026
Member
ZedThree
left a comment
ZedThree
left a comment
There was a problem hiding this comment.
Feels obvious! Thanks @bendudson!
I guess this might plausibly cause issues with the unit tests -- but the simple solution is to take a pointer to a factory and use the singleton if it's nullptr. We'll see if that's necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than creating a new FieldFactory, use the singleton object. This allows users to register new generators and use them to intialise variables.