[2386] SqlServerAdapter::getColumns returns non-associative array #2402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dereuromark
reviewed
Dec 10, 2025
| * | ||
| * @param string $tableName Table name | ||
| * @return \Phinx\Db\Table\Column[] | ||
| * @return list<\Phinx\Db\Table\Column> |
Member
There was a problem hiding this comment.
The former also means non assoc. But it doesnt have the downsides of list<>.
Usually list is too strict as in it has to be the perfect numerical order, which is often kind of pointless.
As return type it is probably fine.
Author
There was a problem hiding this comment.
Usually list is too strict as in it has to be the perfect numerical order
yes) that's why I decided to change it. To be sure that method returns strict list.
Member
|
This probably has to wait until next major. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2386