Skip to content

Coverage report #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sandhi18 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Coverage report #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/ci-main-pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,7 +717,16 @@ jobs:
- name: 'Go unit tests'
if: ${{ inputs.language == 'go' && inputs.unit-tests == true && inputs.build-profile == 'cli' }}
run: |
go test -v ./...
go test -v ./... > ${{ inputs.quality-junit-report }}
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redirecting test output with > will lose stderr and won't capture actual coverage data. The command should use -coverprofile flag to generate proper coverage output (e.g., go test -v -coverprofile=coverage.out ./...), and consider using tee if you need both console output and file output.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output is being redirected to quality-junit-report but go test with -v produces plain text output, not JUnit XML format. To generate JUnit reports, you need a tool like gotestsum or go-junit-report to convert the output.

Copilot uses AI. Check for mistakes.

- name: Upload test coverage artifact
if: ${{ inputs.language == 'go' && inputs.unit-tests == true && inputs.build-profile == 'cli' }}
uses: actions/upload-artifact@v4
with:
# Name of the artifact to upload.
name: test-coverage.out
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The artifact name 'test-coverage.out' is misleading since the captured output is test results in text format, not actual coverage data. Consider renaming to 'test-output' or 'test-results' to accurately reflect the content.

Suggested change
name: test-coverage.out
name: test-results

Copilot uses AI. Check for mistakes.
# A file, directory or wildcard pattern that describes what to upload
path: ${{ inputs.quality-junit-report }}
# run: go test -v -coverprofile="coverage.out" ./... and upload artifact!
# - name: Build for Rust binary
# if: ${{ env.GA_BUILD_LANGUAGE == 'rust' }}
Expand Down