feat(clerk-js,localizations): Add translations in Spanish for taskChooseOrganization json Object #7449
Conversation
…ization json object
🦋 Changeset detectedLatest commit: e02e511 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@fabrobles92 is attempting to deploy a commit to the Clerk Production Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughAdded a changeset and updated Spanish localization files (es-CR, es-ES, es-MX, es-UY) to replace previously undefined keys with concrete translations for taskChooseOrganization (chooseOrganization, createOrganization, signOut) UI strings. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 9
🧹 Nitpick comments (2)
packages/localizations/src/es-CR.ts (1)
855-860: Align “action__suggestionsAccept” wording with the rest of the file (Pedir vs Solicitar).This file already uses both “Pedir unirse” (e.g.,
organizationList.action__suggestionsAccept) and “Solicitar unirse” (e.g.,organizationSwitcher.action__suggestionsAccept). Consider standardizing to one term for the same action to avoid UI inconsistency.packages/localizations/src/es-MX.ts (1)
855-862: Consider aligning “Pedir unirse” wording with existing “Solicitar unirse” to keep Spanish (MX) consistent.
In this same file,organizationSwitcher.action__suggestionsAcceptuses “Solicitar unirse”, while this new segment uses “Pedir unirse”. I’d standardize to one.taskChooseOrganization: { chooseOrganization: { action__createOrganization: 'Crear nueva organización', action__invitationAccept: 'Unirse', - action__suggestionsAccept: 'Pedir unirse', + action__suggestionsAccept: 'Solicitar unirse', subtitle: 'Unirse a una organización existente o crear una nueva', suggestionsAcceptedLabel: 'Pendiente de aprobación', title: 'Elegir una organización', },
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (5)
.changeset/sour-spies-clap.md(1 hunks)packages/localizations/src/es-CR.ts(1 hunks)packages/localizations/src/es-ES.ts(1 hunks)packages/localizations/src/es-MX.ts(1 hunks)packages/localizations/src/es-UY.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (10)
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
All code must pass ESLint checks with the project's configuration
Files:
packages/localizations/src/es-ES.tspackages/localizations/src/es-MX.tspackages/localizations/src/es-CR.tspackages/localizations/src/es-UY.ts
**/*.{js,jsx,ts,tsx,json,md,yml,yaml}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
packages/localizations/src/es-ES.tspackages/localizations/src/es-MX.tspackages/localizations/src/es-CR.tspackages/localizations/src/es-UY.ts
packages/**/src/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
TypeScript is required for all packages
Files:
packages/localizations/src/es-ES.tspackages/localizations/src/es-MX.tspackages/localizations/src/es-CR.tspackages/localizations/src/es-UY.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Follow established naming conventions (PascalCase for components, camelCase for variables)
Files:
packages/localizations/src/es-ES.tspackages/localizations/src/es-MX.tspackages/localizations/src/es-CR.tspackages/localizations/src/es-UY.ts
packages/**/src/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
packages/**/src/**/*.{ts,tsx,js,jsx}: Maintain comprehensive JSDoc comments for public APIs
Use tree-shaking friendly exports
Validate all inputs and sanitize outputs
All public APIs must be documented with JSDoc
Use dynamic imports for optional features
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Implement proper logging with different levels
Files:
packages/localizations/src/es-ES.tspackages/localizations/src/es-MX.tspackages/localizations/src/es-CR.tspackages/localizations/src/es-UY.ts
**/*.ts?(x)
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use proper TypeScript error types
Files:
packages/localizations/src/es-ES.tspackages/localizations/src/es-MX.tspackages/localizations/src/es-CR.tspackages/localizations/src/es-UY.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)
**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoidanytype - preferunknownwhen type is uncertain, then narrow with type guards
Implement type guards forunknowntypes using the patternfunction isType(value: unknown): value is Type
Useinterfacefor object shapes that might be extended
Usetypefor unions, primitives, and computed types
Preferreadonlyproperties for immutable data structures
Useprivatefor internal implementation details in classes
Useprotectedfor inheritance hierarchies
Usepublicexplicitly for clarity in public APIs
Use mixins for shared behavior across unrelated classes in TypeScript
Use generic constraints with bounded type parameters like<T extends { id: string }>
Use utility types likeOmit,Partial, andPickfor data transformation instead of manual type construction
Use discriminated unions instead of boolean flags for state management and API responses
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation at the type level
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Document functions with JSDoc comments including @param, @returns, @throws, and @example tags
Create custom error classes that extend Error for specific error types
Use the Result pattern for error handling instead of throwing exceptions
Use optional chaining (?.) and nullish coalescing (??) operators for safe property access
Let TypeScript infer obvious types to reduce verbosity
Useconst assertionswithas constfor literal types
Usesatisfiesoperator for type checking without widening types
Declare readonly arrays and objects for immutable data structures
Use spread operator and array spread for immutable updates instead of mutations
Use lazy loading for large types...
Files:
packages/localizations/src/es-ES.tspackages/localizations/src/es-MX.tspackages/localizations/src/es-CR.tspackages/localizations/src/es-UY.ts
**/*.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Use ESLint with custom configurations tailored for different package types
Files:
packages/localizations/src/es-ES.tspackages/localizations/src/es-MX.tspackages/localizations/src/es-CR.tspackages/localizations/src/es-UY.ts
**/*.{js,ts,jsx,tsx,json,md,yml,yaml}
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Use Prettier for code formatting across all packages
Files:
packages/localizations/src/es-ES.tspackages/localizations/src/es-MX.tspackages/localizations/src/es-CR.tspackages/localizations/src/es-UY.ts
packages/localizations/**/*
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Organize localization translations in
packages/localizations/with support for 30+ languages and RTL language support
Files:
packages/localizations/src/es-ES.tspackages/localizations/src/es-MX.tspackages/localizations/src/es-CR.tspackages/localizations/src/es-UY.ts
🧠 Learnings (1)
📚 Learning: 2025-12-12T19:54:17.554Z
Learnt from: wobsoriano
Repo: clerk/javascript PR: 7447
File: packages/localizations/src/en-US.ts:904-905
Timestamp: 2025-12-12T19:54:17.554Z
Learning: In Clerk's JavaScript localization files (packages/localizations/src/*.ts), undefined values for localization keys are intentional and should not be flagged as issues. When a key is undefined, the system uses the default message from the API response as a fallback. Do not flag these as errors; preserve this expected behavior.
Applied to files:
packages/localizations/src/es-ES.tspackages/localizations/src/es-MX.tspackages/localizations/src/es-CR.tspackages/localizations/src/es-UY.ts
🔇 Additional comments (2)
packages/localizations/src/es-UY.ts (1)
855-860: LGTM!The translations for the organization selection flow are correct and appropriate for Uruguayan Spanish.
packages/localizations/src/es-ES.ts (1)
857-864: LGTM!The translations in this section are accurate, natural, and consistent with the rest of the file.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (5)
.changeset/sour-spies-clap.md(1 hunks)packages/localizations/src/es-CR.ts(1 hunks)packages/localizations/src/es-ES.ts(1 hunks)packages/localizations/src/es-MX.ts(1 hunks)packages/localizations/src/es-UY.ts(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- .changeset/sour-spies-clap.md
🚧 Files skipped from review as they are similar to previous changes (2)
- packages/localizations/src/es-CR.ts
- packages/localizations/src/es-MX.ts
🧰 Additional context used
📓 Path-based instructions (10)
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
All code must pass ESLint checks with the project's configuration
Files:
packages/localizations/src/es-ES.tspackages/localizations/src/es-UY.ts
**/*.{js,jsx,ts,tsx,json,md,yml,yaml}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
packages/localizations/src/es-ES.tspackages/localizations/src/es-UY.ts
packages/**/src/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
TypeScript is required for all packages
Files:
packages/localizations/src/es-ES.tspackages/localizations/src/es-UY.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Follow established naming conventions (PascalCase for components, camelCase for variables)
Files:
packages/localizations/src/es-ES.tspackages/localizations/src/es-UY.ts
packages/**/src/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
packages/**/src/**/*.{ts,tsx,js,jsx}: Maintain comprehensive JSDoc comments for public APIs
Use tree-shaking friendly exports
Validate all inputs and sanitize outputs
All public APIs must be documented with JSDoc
Use dynamic imports for optional features
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Implement proper logging with different levels
Files:
packages/localizations/src/es-ES.tspackages/localizations/src/es-UY.ts
**/*.ts?(x)
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use proper TypeScript error types
Files:
packages/localizations/src/es-ES.tspackages/localizations/src/es-UY.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)
**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoidanytype - preferunknownwhen type is uncertain, then narrow with type guards
Implement type guards forunknowntypes using the patternfunction isType(value: unknown): value is Type
Useinterfacefor object shapes that might be extended
Usetypefor unions, primitives, and computed types
Preferreadonlyproperties for immutable data structures
Useprivatefor internal implementation details in classes
Useprotectedfor inheritance hierarchies
Usepublicexplicitly for clarity in public APIs
Use mixins for shared behavior across unrelated classes in TypeScript
Use generic constraints with bounded type parameters like<T extends { id: string }>
Use utility types likeOmit,Partial, andPickfor data transformation instead of manual type construction
Use discriminated unions instead of boolean flags for state management and API responses
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation at the type level
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Document functions with JSDoc comments including @param, @returns, @throws, and @example tags
Create custom error classes that extend Error for specific error types
Use the Result pattern for error handling instead of throwing exceptions
Use optional chaining (?.) and nullish coalescing (??) operators for safe property access
Let TypeScript infer obvious types to reduce verbosity
Useconst assertionswithas constfor literal types
Usesatisfiesoperator for type checking without widening types
Declare readonly arrays and objects for immutable data structures
Use spread operator and array spread for immutable updates instead of mutations
Use lazy loading for large types...
Files:
packages/localizations/src/es-ES.tspackages/localizations/src/es-UY.ts
**/*.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Use ESLint with custom configurations tailored for different package types
Files:
packages/localizations/src/es-ES.tspackages/localizations/src/es-UY.ts
**/*.{js,ts,jsx,tsx,json,md,yml,yaml}
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Use Prettier for code formatting across all packages
Files:
packages/localizations/src/es-ES.tspackages/localizations/src/es-UY.ts
packages/localizations/**/*
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Organize localization translations in
packages/localizations/with support for 30+ languages and RTL language support
Files:
packages/localizations/src/es-ES.tspackages/localizations/src/es-UY.ts
🧠 Learnings (1)
📚 Learning: 2025-12-12T19:54:17.554Z
Learnt from: wobsoriano
Repo: clerk/javascript PR: 7447
File: packages/localizations/src/en-US.ts:904-905
Timestamp: 2025-12-12T19:54:17.554Z
Learning: In Clerk's JavaScript localization files (packages/localizations/src/*.ts), undefined values for localization keys are intentional and should not be flagged as issues. When a key is undefined, the system uses the default message from the API response as a fallback. Do not flag these as errors; preserve this expected behavior.
Applied to files:
packages/localizations/src/es-ES.tspackages/localizations/src/es-UY.ts
🔇 Additional comments (3)
packages/localizations/src/es-ES.ts (1)
847-870: LGTM! Translations are accurate and consistent.The Spanish translations for
taskChooseOrganizationare well done:
- Proper use of formal "usted" register appropriate for es-ES (Spain)
- Correct spelling with accents ("sesión")
- Locale-appropriate terminology ("Sesión iniciada como" instead of Latin American "Logueado como")
- Consistent with similar translations elsewhere in the file
packages/localizations/src/es-UY.ts (2)
855-856: LGTM! Translations are accurate.The chooseOrganization translations are well done and consistent with Uruguayan Spanish conventions.
Also applies to: 858-860
863-874: LGTM! Proper Uruguayan Spanish conventions followed.The createOrganization and signOut translations correctly use:
- Informal "vos" register (Ingresá, tu) appropriate for es-UY
- Correct spelling with accents (sesión)
- Latin American terminology (Logueado como) suitable for Uruguay
jigar-clerk
changed the title
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ization json object
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…ns_taskChooseOrganization' into feat/add_spanish_translations_taskChooseOrganization # Conflicts: # .changeset/sour-spies-clap.md
|
Closing this in favor of: #7468 |
3 participants
Description
There is a clerk component I am rendering for the Spanish audience in my app that does not have translation in spanish and shows nothing:
Translation of English version:
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.