Skip to content

Conversation

@octoper
Copy link
Member

@octoper octoper commented Dec 15, 2025

Description

Port of #7443 to Core 2

This fixes a previously introduced bug that was not awaiting the navigateOnSetActive in setActive called on password submit on sign-in.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel
Copy link

vercel bot commented Dec 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Dec 15, 2025 9:40am

@changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2025

🦋 Changeset detected

Latest commit: 1e58ab7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 15, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch vaggelis/port-7443-to-core-2

Comment @coderabbitai help to get the list of available commands and usage tips.

@octoper octoper requested a review from Ephem December 15, 2025 09:40
@octoper octoper self-assigned this Dec 15, 2025
Copy link
Member

@Ephem Ephem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 15, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7459

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7459

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7459

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7459

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7459

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7459

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@7459

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@7459

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7459

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7459

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7459

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7459

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7459

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7459

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@7459

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7459

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@7459

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7459

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7459

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7459

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@7459

@clerk/types

npm i https://pkg.pr.new/@clerk/types@7459

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7459

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7459

commit: 1e58ab7

@octoper octoper merged commit 28c56ca into release/core-2 Dec 15, 2025
77 of 78 checks passed
@octoper octoper deleted the vaggelis/port-7443-to-core-2 branch December 15, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants