Define TableName and ReducerName backed by EcoString
#4137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
centri/table-reducer-name
branch
from
2c8cfc5 to
340667d
Compare
gefjon
reviewed
Jan 27, 2026
gefjon
approved these changes
Jan 27, 2026
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
As discussed with Mazdak out of band:
- He will change codegen before merging.
- He agrees that
FunctionNamewould be better, but will put that off until a future refactor due to time pressure of the keynote benchmarks.
Centril
force-pushed
the
centri/table-reducer-name
branch
from
340667d to
e949fba
Compare
define `ReducerName` backed by `EcoString`
Centril
force-pushed
the
centri/table-reducer-name
branch
from
e949fba to
835cbd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The first commit defines a type
TableNamethat is used in e.g.,TxDataand where determined profitable and necessary to do this change.TableNameis backed byecow::EcoStringwhich affords O(1) clones and 15 bytes of inline storage andmem::size_of::<EcoString>() == 16.The second commit does the same for
ReducerName. This is also used in reducer execution.Together, these commits increase TPS by around 5-7k TPS.
API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
Covered by existing tests.