included add config and show config features#3
Open
babarinde wants to merge 1 commit intocloudControl:masterfrom
Open
included add config and show config features#3babarinde wants to merge 1 commit intocloudControl:masterfrom
babarinde wants to merge 1 commit intocloudControl:masterfrom
Conversation
Contributor
|
Thank you for the pull request. I think the added functionality is fine. |
Author
|
Hi @TooAngel, as when i try to add some config variables i get this error I also try changing the request to a PUT but i get the same error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @pst,
Add config and Show Config features added
One issue with implementing the remove config was, passing the variables seem to be a challenge.
In https://github.com/cloudControl/cctrl/blob/master/cctrl/app.py#L740 ,
args.variables expects to be an array (i think) as defined in
https://github.com/cloudControl/cctrl/blob/5fcdca83fc6fb26676b1ff3aa4f241663aa400de/cctrl/addonoptionhelpers.py#L69
getting an array of the keys to the delete http request is quite a challenge.
This is my first encounter with python so i guess my assumptions are quite right.
Cheers