-
Notifications
You must be signed in to change notification settings - Fork 477
DOC-15514: Product Change- PR #158499 - sql: show KV CPU Time in EXPLAIN ANALYZE #21727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
Files changed: |
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
florence-crl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alyshanjahani-crl please take another look.
peachdawnleach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except one clarifying question
| `network usage` | The amount of data transferred over the network while the statement was executed. If the value is 0 B, the statement was executed on a single node and didn't use the network. | ||
| `regions` | The [regions]({% link {{ page.version.version }}/show-regions.md %}) where the affected nodes were located. | ||
| `sql cpu time` | The total amount of time spent in the [SQL layer]({% link {{ page.version.version }}/architecture/sql-layer.md %}). It does not include time spent in the [storage layer]({% link {{ page.version.version }}/architecture/storage-layer.md %}). | ||
| `kv cpu time` | The total amount of time spent in the [KV layer]({% link {{ page.version.version }}/architecture/overview.md %}#layers) on the critical path of serving the query. Excludes time spent on asynchronous replication and in the [storage layer]({% link {{ page.version.version }}/architecture/storage-layer.md %}). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This links to a section about different layers, but the "KV layer" is not one of the layers mentioned. I'm guessing that "KV layer" is more of an overarching term rather than a specific layer, but I may be misunderstanding something. Approving the PR but this might need a bit of clarification unless there's just some common knowledge that I don't know here
Fixes DOC-15514
In explain-analyze.md, in Global properties, added kv cpu time.
Rendered preview