Skip to content

Conversation

@hanna-skryl
Copy link
Collaborator

Closes #931

  • Made patterns optional in ESLint plugin configuration with default to current directory ('.')
  • Made the config parameter of eslintPlugin() optional
  • Fixed README artifacts examples (were incorrectly showing artifacts in the first parameter)
  • Added unit tests for eslintPluginConfigSchema and eslintTargetSchema
  • Added integration tests for optional config scenarios

@hanna-skryl hanna-skryl self-assigned this Dec 31, 2025
@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 eslint-plugin labels Dec 31, 2025
@nx-cloud
Copy link

nx-cloud bot commented Dec 31, 2025

View your CI Pipeline Execution ↗ for commit d3904e7

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 5s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 21s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 11m 39s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 1m 5s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-31 20:15:30 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 31, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1200

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1200

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1200

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1200

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1200

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1200

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1200

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1200

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1200

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1200

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1200

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1200

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1200

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1200

commit: d3904e7

@github-actions
Copy link
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 479886a with previous commit f51d768.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 41 🔴 40 ↓ −0.5
Documentation 🔴 36 🔴 36 ↑ +0.1
Code coverage 🟡 89 🟡 89 ↑ +0.1
Axe Accessibility 🟡 88 🟡 88 ↓ −0.1
Bug prevention 🟡 67 🟡 67
Code style 🟢 99 🟢 99
Security 🟡 51 🟡 51
Updates 🟡 79 🟡 79
Type Safety 🟡 56 🟡 56
Miscellaneous 🟡 67 🟡 67
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟢 92 🟢 92
👍 2 groups improved, 👎 1 group regressed, 👍 5 audits improved, 👎 2 audits regressed, 16 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 41 🔴 40 ↓ −0.5
JSDocs coverage Documentation coverage 🔴 36 🔴 36 ↑ +0.1
Code coverage Code coverage metrics 🟡 89 🟡 89 ↑ +0.1

31 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟨 5.6 s 🟥 6.4 s ↑ +14.9 %
Lighthouse First Contentful Paint 🟥 3.2 s 🟥 3.0 s ↓ −4.9 %
Lighthouse Time to Interactive 🟥 12.5 s 🟥 12.7 s ↑ +2 %
Lighthouse Total Blocking Time 🟥 1,220 ms 🟥 1,190 ms ↓ −2.1 %
JSDocs coverage Variables coverage 🟥 267 undocumented variables 🟥 265 undocumented variables ↓ −0.7 %
Code coverage Branch coverage 🟨 87.2 % 🟨 87.2 % ↑ +0.1 %
Code coverage Line coverage 🟨 84.7 % 🟨 84.7 % ↑ +0.1 %
Lighthouse Minimizes main-thread work 🟥 8.2 s 🟥 8.8 s ↑ +7.4 %
Lighthouse JavaScript execution time 🟥 3.2 s 🟥 3.7 s ↑ +17 %
Lighthouse Server Backend Latencies 🟩 1,260 ms 🟩 1,800 ms ↑ +42.5 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↑ +0.1 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +2 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 95 KiB 🟥 Potential savings of 95 KiB ↓ −29.7 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 105 KiB 🟥 Potential savings of 105 KiB ↓ −29.7 %
Lighthouse Max Potential First Input Delay 🟥 880 ms 🟥 1,040 ms ↑ +18.5 %
Lighthouse Largest Contentful Paint 🟥 11.6 s 🟥 11.8 s ↑ +1.2 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 190 KiB 🟥 Potential savings of 190 KiB ↓ −4.2 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,065 KiB 🟩 Total size was 2,065 KiB ↓ −0.1 %
JS packages Vulnerabilities for npm dev dependencies. 🟥 24 vulnerabilities (3 critical, 6 high, 9 moderate, 6 low) 🟥 40 vulnerabilities (3 critical, 23 high, 8 moderate, 6 low) ↑ +66.7 %
Lighthouse Initial server response time was short 🟩 Root document took 470 ms 🟩 Root document took 460 ms ↓ −2.5 %
TypeScript Semantic errors 🟥 2581 errors 🟥 2590 errors ↑ +0.3 %
Lighthouse Network Round Trip Times 🟩 30 ms 🟩 20 ms ↓ −32.9 %
Lighthouse Cumulative Layout Shift 🟩 0 🟩 0 ↓ −100 %

656 other audits are unchanged.

@github-actions
Copy link
Contributor

Code PushUp

🥳 Code PushUp report has improved – compared current commit 479886a with previous commit f51d768.

💼 Project plugin-eslint

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🟡 66 🟡 67 ↑ +1.1
Code coverage 🟢 94 🟢 94 ↑ +0.2

4 other categories are unchanged.

👍 2 groups improved, 👍 3 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🟡 66 🟡 67 ↑ +1.1
Code coverage Code coverage metrics 🟢 94 🟢 94 ↑ +0.2

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDocs coverage Variables coverage 🟥 15 undocumented variables 🟥 13 undocumented variables ↓ −13.3 %
Code coverage Branch coverage 🟨 84.7 % 🟨 85.2 % ↑ +0.7 %
Code coverage Line coverage 🟩 92.5 % 🟩 92.6 % ↑ +0.1 %

441 other audits are unchanged.


13 other projects are unchanged.

@hanna-skryl hanna-skryl marked this pull request as ready for review December 31, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧩 eslint-plugin 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Defaults in eslint plugin to avoid config code

2 participants