Skip to content

Conversation

@BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Jan 13, 2026

Related: #1197

This PR includes:

  • bump node version of utils to 18.2.0 as of a lint error The 'perf_hooks.PerformanceMark' is still an experimental feature and is not supported until Node.js 18.2.0 (backported: ^16.17.0). The configured version range is '>=17.0.0'
  • types for trace events and file
  • utils for trace events and trace file generation
  • epoch clock API extension

@nx-cloud
Copy link

nx-cloud bot commented Jan 13, 2026

View your CI Pipeline Execution ↗ for commit 878b939

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 4s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 20s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 11m 34s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 48s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-14 05:08:02 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 13, 2026

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1215

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1215

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1215

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1215

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1215

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1215

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1215

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1215

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1215

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1215

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1215

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1215

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1215

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1215

commit: 878b939

@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2026

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit c78f386 with previous commit 7d3681c.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🔴 34 🔴 35 ↑ +1.1
Performance 🔴 37 🔴 37 ↓ −0.6
Code coverage 🟢 91 🟢 91 ↓ −0.1
Bug prevention 🟡 75 🟡 75 ↓ −0.1
Axe Accessibility 🟡 88 🟡 88 ↓ −0.1
Code style 🟢 99 🟢 99
Security 🟡 51 🟡 51
Updates 🟡 78 🟡 78
Type Safety 🟡 67 🟡 67
Miscellaneous 🟡 67 🟡 67
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟢 92 🟢 92
👍 1 group improved, 👎 2 groups regressed, 👍 6 audits improved, 👎 2 audits regressed, 17 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🔴 34 🔴 35 ↑ +1.1
Lighthouse Performance 🔴 37 🔴 37 ↓ −0.6
Code coverage Code coverage metrics 🟢 91 🟢 91 ↓ −0.1

31 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse First Contentful Paint 🟥 3.0 s 🟥 3.3 s ↑ +9.7 %
JSDocs coverage Types coverage 🟥 260 undocumented types 🟥 265 undocumented types ↑ +1.9 %
JSDocs coverage Variables coverage 🟥 271 undocumented variables 🟥 275 undocumented variables ↑ +1.5 %
Lighthouse Total Blocking Time 🟥 1,990 ms 🟥 1,860 ms ↓ −6.6 %
Code coverage Line coverage 🟨 86.2 % 🟨 85.4 % ↓ −0.9 %
JSDocs coverage Functions coverage 🟥 597 undocumented functions 🟥 598 undocumented functions ↑ +0.2 %
Code coverage Function coverage 🟩 93.4 % 🟩 93.5 % ↑ +0.1 %
Code coverage Branch coverage 🟨 87.3 % 🟨 87.3 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,113 KiB 🟩 Total size was 2,123 KiB ↑ +0.5 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 31 resources found ↑ +0.1 %
Lighthouse Minimizes main-thread work 🟥 8.9 s 🟥 8.4 s ↓ −6.1 %
Lighthouse JavaScript execution time 🟥 4.4 s 🟥 4.0 s ↓ −10.1 %
Lighthouse Largest Contentful Paint 🟥 11.4 s 🟥 11.2 s ↓ −2.4 %
Lighthouse Max Potential First Input Delay 🟥 1,040 ms 🟥 830 ms ↓ −20.6 %
Lighthouse Initial server response time was short 🟩 Root document took 400 ms 🟩 Root document took 560 ms ↑ +42.1 %
Lighthouse Time to Interactive 🟥 13.0 s 🟥 13.2 s ↑ +1.2 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +1.2 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 103 KiB 🟥 Potential savings of 105 KiB ↓ −31.1 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 95 KiB 🟥 Potential savings of 95 KiB ↓ −21.7 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 200 KiB 🟥 Potential savings of 223 KiB ↓ −11.3 %
Lighthouse Server Backend Latencies 🟩 1,050 ms 🟩 1,140 ms ↑ +8.4 %
Lighthouse Network Round Trip Times 🟩 0 ms 🟩 50 ms ↑ +1002.2 %
Lighthouse Speed Index 🟥 5.9 s 🟥 5.9 s ↓ −0.1 %
JS packages Outdated npm dev dependencies. 🟨 55 outdated package versions (29 major, 19 minor, 7 patch) 🟨 56 outdated package versions (29 major, 19 minor, 8 patch) ↑ +1.8 %
JSDocs coverage Properties coverage 🟥 24 undocumented properties 🟥 23 undocumented properties ↓ −4.2 %

654 other audits are unchanged.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2026

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit c78f386 with previous commit 7d3681c.

💼 Project utils

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🔴 36 🔴 39 ↑ +3.4
Code coverage 🟢 94 🟢 94 ↓ −0.3

4 other categories are unchanged.

👍 1 group improved, 👎 1 group regressed, 👍 4 audits improved, 👎 2 audits regressed, 1 audit changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🔴 36 🔴 39 ↑ +3.4
Code coverage Code coverage metrics 🟢 94 🟢 94 ↓ −0.3

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDocs coverage Variables coverage 🟥 43 undocumented variables 🟥 47 undocumented variables ↑ +9.3 %
JSDocs coverage Types coverage 🟥 59 undocumented types 🟥 64 undocumented types ↑ +8.5 %
Code coverage Line coverage 🟩 93.8 % 🟨 89.9 % ↓ −4.2 %
JSDocs coverage Functions coverage 🟥 246 undocumented functions 🟥 247 undocumented functions ↑ +0.4 %
Code coverage Function coverage 🟩 95.8 % 🟩 96 % ↑ +0.2 %
Code coverage Branch coverage 🟩 91.8 % 🟩 91.7 % ↓ −0.2 %
JSDocs coverage Properties coverage 🟥 24 undocumented properties 🟥 23 undocumented properties ↓ −4.2 %

437 other audits are unchanged.

💼 Project plugin-lighthouse

😟 Code PushUp report has regressed.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 99 🟢 99 ↓ −0.1

5 other categories are unchanged.

👎 1 group regressed, 👎 1 audit regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 99 🟢 99 ↓ −0.1

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟩 96.2 % 🟩 96.2 % ↓ −0.1 %

443 other audits are unchanged.


12 other projects are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review January 13, 2026 22:27
@BioPhoton BioPhoton requested a review from hanna-skryl January 13, 2026 22:41
Comment on lines +45 to +49
const fromEntry = (entry: PerformanceEntry, useEndTime = false) =>
defaultClock.fromPerfMs(
entry.startTime +
(entry.entryType === 'measure' && useEndTime ? entry.duration : 0),
);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does fromEntry use defaultClock.fromPerfMs instead of the local fromPerfMs?

Comment on lines +76 to +109
it('should convert performance mark to microseconds', () => {
const markEntry = {
name: 'test-mark',
entryType: 'mark',
startTime: 1000,
duration: 0,
} as PerformanceMark;

expect(defaultClock.fromEntry(markEntry)).toBe(
defaultClock.fromPerfMs(1000),
);
expect(defaultClock.fromEntry(markEntry, true)).toBe(
defaultClock.fromPerfMs(1000),
);
});

it('should convert performance measure to microseconds', () => {
const measureEntry = {
name: 'test-measure',
entryType: 'measure',
startTime: 1000,
duration: 500,
} as PerformanceMeasure;

expect(defaultClock.fromEntry(measureEntry)).toBe(
defaultClock.fromPerfMs(1000),
);
expect(defaultClock.fromEntry(measureEntry, false)).toBe(
defaultClock.fromPerfMs(1000),
);
expect(defaultClock.fromEntry(measureEntry, true)).toBe(
defaultClock.fromPerfMs(1500),
);
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a type mismatch - fromEntry expects PerformanceEntry but only uses some of its properties. The type assertion doesn't help here.

Narrowing the signature to what's actually needed fixes it: Pick<PerformanceEntry, 'duration' | 'startTime' | 'entryType'>.

Then, tests can use satisfies instead of type casting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants