-
Notifications
You must be signed in to change notification settings - Fork 0
Feature Update #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Update #94
Conversation
…put was focused before
…meEntryCreateModal from web
…ing in the rows mounting the rows mounts lots of nested components which results in a delay on the initial mount.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces a new permission system for employees to manage tasks based on an organization setting (employees_can_manage_tasks), refactors the UI package structure for better code sharing between the main app and desktop app, and includes various component improvements and dependency updates.
Key Changes:
- Adds
employees_can_manage_tasksorganization setting with comprehensive permission checks - Refactors Tailwind theme configuration into a shared package for reusability
- Adds new UI components (Tooltip, Button variants, TimeTrackerMoreOptionsDropdown)
- Updates API client with new organization fields
- Improves time entry handling with better support for running timers
Reviewed changes
Copilot reviewed 82 out of 88 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tests/Unit/Service/PermissionStoreTest.php |
Adds comprehensive tests for employee task permission system |
tests/Unit/Endpoint/Api/V1/TaskEndpointTest.php |
Updates tests to use :all permissions and adds employee permission tests |
tests/Unit/Endpoint/Api/V1/ClientEndpointTest.php |
Adds clients:view:all permission to existing tests |
tests/Unit/Console/KernelTest.php |
New test file for console kernel scheduling |
tsconfig.json |
Adds path mapping for @solidtime/ui package |
tailwind.config.js |
Refactors theme into shared package |
resources/js/packages/ui/tailwind.theme.js |
New shared theme configuration |
resources/js/packages/ui/styles.css |
New shared CSS styles |
resources/js/utils/useTimeEntries.ts |
Refactors store with explicit return types and improved error handling |
resources/js/utils/useCurrentTimeEntry.ts |
Adds support for stopping timer by setting end time |
resources/js/utils/notification.ts |
Changes route('login') to hardcoded '/login' |
| Various UI components | New components and refactored existing ones for better modularity |
| Package files | Version bumps and dependency updates |
Files not reviewed (1)
- resources/js/packages/api/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.