Skip to content

fix: signal registration for windows #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michalsn merged 1 commit into from
Dec 18, 2025
+6 −2
Merged

fix: signal registration for windows #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Compatibility/SignalTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,17 @@ protected function isPosixAvailable(): bool
* @param array<int, string> $methodMap Optional signal-to-method mapping
*/
protected function registerSignals(
array $signals = [SIGTERM, SIGINT, SIGHUP, SIGQUIT],
array $signals = [],
array $methodMap = [],
): void {
if (! $this->isPcntlAvailable()) {
return;
}

if ($signals === []) {
$signals = [SIGTERM, SIGINT, SIGHUP, SIGQUIT];
}

if (! $this->isPosixAvailable() && (in_array(SIGTSTP, $signals, true) || in_array(SIGCONT, $signals, true))) {
CLI::write('POSIX extension is not available. SIGTSTP and SIGCONT signals will be disabled.', 'yellow');
$signals = array_diff($signals, [SIGTSTP, SIGCONT]);
Expand Down
2 changes: 1 addition & 1 deletion stubs/SignalTrait.phpstub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ trait SignalTrait
* @param list<int> $signals
* @param array<int, string> $methodMap
*/
protected function registerSignals(array $signals = [SIGTERM, SIGINT, SIGHUP, SIGQUIT], array $methodMap = []): void
protected function registerSignals(array $signals = [], array $methodMap = []): void
{
}

Expand Down
Loading