🤖 fix: keep workspace creation loading overlay during hydration#2685
🤖 fix: keep workspace creation loading overlay during hydration#2685
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
jaaydenh
force-pushed
the
fix/workspace-creation-loading-transition
branch
from
c2251ab to
492a114
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 492a114d2c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jaaydenh
force-pushed
the
fix/workspace-creation-loading-transition
branch
from
492a114 to
5c2d14e
Compare
|
@codex review Addressed the stale workspace-creation transition cleanup by clearing the transition when the active workspace route no longer matches the transition target (including leaving to project/home routes). |
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Preserve the creation overlay across the ProjectPage -> WorkspaceShell transition to avoid showing two sequential loading screens on mobile. App now tracks the newly-created workspace transition and clears it once WorkspaceShell reports hydration complete. --- _Generated with `mux` • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh` • Cost: `$2.13`_ <!-- mux-attribution: model=openai:gpt-5.3-codex thinking=xhigh costs=2.13 -->
jaaydenh
force-pushed
the
fix/workspace-creation-loading-transition
branch
from
5c2d14e to
3f640a5
Compare
|
@codex review Rebased on latest main, resolved merge conflicts, and re-validated. Please do another pass. |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Keep the workspace-creation loading experience continuous across navigation by preserving the existing creation overlay until the new workspace finishes hydrating.
Background
On mobile, creating a workspace showed two back-to-back loading screens with a restarted animation:
Creating workspaceoverlay fromProjectPageLoading workspace...placeholder fromWorkspaceShellBecause the sidebar is collapsed on mobile, both appeared full-screen and looked like a redundant second loading screen.
Implementation
App.tsxto carry creation overlay metadata (workspaceId, name/title).onWorkspaceCreatedbefore auto-navigation.CreationCenterContentas an absolute overlay in the main pane while transitioning.onWorkspaceHydratedplumbing (App -> AIView -> WorkspaceShell) and clear the transition state onceworkspaceState.loadingis false.Validation
make static-checkRisks
Generated with
mux• Model:openai:gpt-5.3-codex• Thinking:xhigh• Cost:$2.13