Update & maintenance #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update PHPStan level from 8 to 9 (strictest) - Add type-safe helper methods in Helpers class for array access - Update all Schema classes to use type-safe helpers - Update README.md to match template (heatbadger URL, badges, versions table) - Update LICENSE year to 2025 - Update GitHub workflow cron schedules to match template
- Convert all Schema test files from TestCase to Toolkit::test() pattern - Use .phpt extension as per Contributte standards
f3l1x
commented
Dec 29, 2025
| /** | ||
| * @param mixed[] $data | ||
| */ | ||
| public static function fromArray(array $data): Contact |
Member
Author
There was a problem hiding this comment.
Add proper phpdoc with array shape
| */ | ||
| public static function fromArray(array $data): self | ||
| { | ||
| $encoding = new Encoding(); |
Member
Author
There was a problem hiding this comment.
Add proper array shape phpdoc
- Remove type-safe accessor methods from Helpers class (getString, getStringOrNull, etc.) - Keep only the merge() utility function in Helpers - Add inline @var annotations in Schema classes for PHPStan level 9 compatibility - Remove Helpers imports from Schema files that no longer need it
Replace generic mixed[] type annotations with specific array shape phpdocs on all Schema::fromArray() methods. This provides better IDE support and type safety for PHPStan level 9. Array shapes specify the exact structure expected by each fromArray() method, including required and optional keys with their types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.