Skip to content

if old and newly selected source are the same, still trigger selectSource event#18241

Merged
brandonkelly merged 4 commits into5.xfrom
bugfix/element-index-select-source-event
Jan 15, 2026
Merged

if old and newly selected source are the same, still trigger selectSource event#18241
brandonkelly merged 4 commits into5.xfrom
bugfix/element-index-select-source-event

Conversation

@i-just
Copy link
Contributor

@i-just i-just commented Jan 14, 2026

Description

Follow up to e1b2363

When reloading or revisiting an element index page, the red "New {type}" button (e.g. New entry, New category) wasn’t showing unless you switched to another source first.

That’s because the changes from the above commit were preventing the selectSource event from being triggered, which means that this binding wasn’t triggered, and the button was not being added.

Related issues

n/a

@i-just i-just requested a review from brandonkelly January 14, 2026 13:22
@brandonkelly brandonkelly merged commit 7680cb1 into 5.x Jan 15, 2026
2 checks passed
@brandonkelly brandonkelly deleted the bugfix/element-index-select-source-event branch January 15, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants