Open
Conversation
Member
|
Thanks for the contribution! I don't mind having an extra data set generated for those that would prefer to have the ability to look up symbols by their respective currency name, so can you add a section to the README which discusses the generated file, with an example of how to use it? Thanks! P.S: I deleted one of your comments above because there were two comments with the same content. |
Member
|
And you will want to add a unit test. Nothing elaborate, just a check to ensure that nothing we do causes a regression or a break the expected formatting of the object. |
|
RBTQ Realbank |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be nice if it can build a JSON file that maps the coins' name to symbols. I added a few lines in build.js, and it will create name-to-symbol.js by running
$ npm run build