Add cursor to visitor#34
Open
ashtonsix wants to merge 1 commit intoctrlplusb:masterfrom
ashtonsix:patch-1
Open
Add cursor to visitor#34ashtonsix wants to merge 1 commit intoctrlplusb:masterfrom ashtonsix:patch-1
ashtonsix wants to merge 1 commit intoctrlplusb:masterfrom
ashtonsix:patch-1
Conversation
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
=======================================
Coverage 95.29% 95.29%
=======================================
Files 1 1
Lines 85 85
Branches 24 24
=======================================
Hits 81 81
Misses 4 4
Continue to review full report at Codecov.
|
Owner
|
This seems like a super interesting idea and could open up some powerful ideas. I'll need to give it a thorough bashing before we merge, but i feel like it holds a lot of promise. Thanks so much for this proposal! |
Author
|
@ctrlplusb how's the bashing going? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets us do stuff that depends on knowing where the node we're visiting is.
For example, I noticed
<v:roundrect />is invalid butReact.createElement('v:roundrect')is fine, so wrote some code like<v$roundrect />& a function that can find/replace$with:after an intermediate build step.