-
Notifications
You must be signed in to change notification settings - Fork 14
add full name property and deactivable method to User #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe User resource class now includes the Deactivable mixin in its inheritance list and exposes a new read-only property Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #435 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 54 54
Lines 1190 1194 +4
=========================================
+ Hits 1190 1194 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
139d83b to
2178227
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@cuenca/resources/users.py`:
- Around line 98-101: The full_name property can include literal "None" when
names/first_surname/second_surname are missing; update the full_name property to
build the name by collecting names, first_surname, and second_surname, filtering
out None or empty strings, and then joining the remaining parts with a single
space (referencing the full_name property and the attributes names,
first_surname, second_surname); ensure the final result is stripped and returns
an empty string when all parts are absent.
Summary by CodeRabbit
New Features
Tests
Chores
✏️ Tip: You can customize this high-level summary in your review settings.