[WIP] curve: enable the unreachable_pub lint
#851
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note: I only ran |
In #850 I noticed there are a lot of places that internal types are currently marked `pub` which is a bit confusing when trying to reason about whether APIs allow for violating invariants. This enables the `unreachable_pub` lint which can automatically check for such situations. Most of them were corrected automatically using `cargo fix`
tarcieri
force-pushed
the
curve/unreachable_pub
branch
from
0ac2d01 to
b7cf702
Compare
Contributor
Author
|
Per #855 I guess this shouldn't apply to anything in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #850 I noticed there are a lot of places that internal types are currently marked
pubwhich is a bit confusing when trying to reason about whether APIs allow for violating invariants.This enables the
unreachable_publint which can automatically check for such situations. Most of them were corrected automatically usingcargo fix