added basic support for MockQueue#unsubscribe#4
Open
jsaedtler wants to merge 1 commit intodanielsdeleo:masterfrom
Open
added basic support for MockQueue#unsubscribe#4jsaedtler wants to merge 1 commit intodanielsdeleo:masterfrom
jsaedtler wants to merge 1 commit intodanielsdeleo:masterfrom
Conversation
|
Hey @danielsdeleo, I'm currently facing the same issue @jsaedtler described above. Could this be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Dan,
i came about an issue when using moqueue on different specs in another project where moqueue is used to mock the mq parts. It raised the DoubleSubscribeError even after calling unsubscrube on the mocked queue.
After browsing your source i found that unsubscribe is implemented rather small, so i tried to fix it. It works for me and i added an spec.
What do you think of my proposal?
Thanks
Jörg