provide proper barebones compiler defines for selfcheck and daca #4954
+17
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
firewave
added
the
merge-after-next-release
Collaborator
Author
|
Should be merged after #5420 has landed. |
firewave
force-pushed
the
self-def
branch
2 times, most recently
from
34653af to
bae9b50
Compare
danmar
reviewed
Nov 15, 2023
| #if defined(__GNUC__) \ | ||
| || defined(__clang__) \ | ||
| || defined(__CPPCHECK__) | ||
| || defined(__clang__) |
Owner
There was a problem hiding this comment.
How will it work when I run selfcheck manually on the command line? Before I only had to provide -D__CPPCHECK__ to get reasonable results. It seems tedious to provide all gnu preprocessor flags manually.
I run cppcheck selfcheck manually sometimes..
Collaborator
Author
…bian bullseye compiler) for selfcheck and daca / removed unnecessary checks for `__CPPCHECK__` [skip ci]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.