This repository was archived by the owner on Apr 17, 2018. It is now read-only.
Rebase ardm changes on top of most recent DM master to make this releasable as dm-active_model 1.3#5
Open
martinemde wants to merge 8 commits intodatamapper:masterfrom
Open
Rebase ardm changes on top of most recent DM master to make this releasable as dm-active_model 1.3#5martinemde wants to merge 8 commits intodatamapper:masterfrom
martinemde wants to merge 8 commits intodatamapper:masterfrom
Conversation
We previously were relying on Lint to never add new tests.
martinemde
force-pushed
the
dm-master-rebase
branch
from
a78f24a to
dcb7bf3
Compare
Member
|
@martinemde This looks good, except for the version number changes. We're not yet ready to release 1.3.0, I'm still working on it all. I appreciate all this work though, and I'm going to try to get it merged. |
Author
|
I'll remove b677a32 from the commits in this PR. While I have your attention, before I left Engine Yard I had nearly the complete set of DM gems working in our app on modern rails. I don't use DataMapper anymore, but https://github.com/ar-dm contains all the gems in working condition to run on rails4+. If you're looking for solutions to the problems, I solved everything sufficient for production deploy on the ardm versions. |
martinemde
force-pushed
the
dm-master-rebase
branch
from
dcb7bf3 to
7b94e0d
Compare
Member
|
Thanks @martinemde, will definitely take a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my work to modernize this dm gem for release as ardm-* scoped gem.