#174864453 builds user up/in using Facebook OAuth#35
Open
#174864453 builds user up/in using Facebook OAuth#35
Conversation
…eer/code-jammers-backend into ft-user-sign-in-174566162
a user can sign up or create an account
…eer/code-jammers-backend into ft-user-sign-in-174566162
Fiyin-Anne
previously approved these changes
Nov 2, 2020
bellogo
previously approved these changes
Nov 2, 2020
feobaby
requested changes
Nov 3, 2020
Contributor
feobaby
left a comment
feobaby
left a comment
There was a problem hiding this comment.
Please work on the reviews given to you on slack.
…ackend into ft-facebook-user-singup/in-oauth-174864453
…ackend into ft-facebook-user-singup/in-oauth-174864453
feobaby
reviewed
Nov 6, 2020
src/database/config/fbpassport.js
Outdated
| callbackURL: process.env.FACEBOOK_CALLBACK_URL, | ||
| profileFields: ["id", "name", "email", "displayName"] | ||
| }, | ||
| async (accessToken, refreshToken, profile, done) => { |
Contributor
There was a problem hiding this comment.
use classes and static methods for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
Description of tasks to be completed?
How should this be manually tested/checked?
ft-facebook-user-singup/in-oauth-174864453npm installnpm run dev.env fileand define the following as follows:DEV_DATABASE_URL = <development database url>TEST_DATABASE_URL = <test database url>DATABASE_URL = <production database url>What are the relevant pivotal tracker stories?
#174864453