Skip to content

Conversation

@cmrigney
Copy link
Contributor

@cmrigney cmrigney commented Dec 3, 2025

What I did

This fulfills what this other PR promises. When the profiles feature flag is on and no profile is specified, we use the "default" profile.

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +82 to +85
} else if options.WorkingSet == "" {
// ELSE we're in working set mode,
// so IF no profile specified, use the default profile
options.WorkingSet = "default"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Default profile overrides session flag

With the profiles feature enabled, the run handler defaults options.WorkingSet to "default" whenever no legacy flags are set. The legacy detection omits the --session flag, so invoking docker-mcp gateway run --session <name> now falls into this block and forces working-set mode, causing Gateway.NewGateway to ignore the session-specific file-based configuration and load the default profile instead. This regresses session usage whenever the profiles feature flag is enabled and only --session is provided.

Useful? React with 👍 / 👎.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will open a follow up PR for this.

@cmrigney cmrigney merged commit 3c51ecc into main Dec 3, 2025
8 checks passed
@cmrigney cmrigney deleted the use-default-profile branch December 3, 2025 20:56
null-runner pushed a commit to null-runner/mcp-gateway that referenced this pull request Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants