ci: update-go workflow to keep go version in sync #321
+175
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <[email protected]>
Collaborator
|
For containerd, perhaps we could just read it from https://github.com/containerd/containerd/blob/fcf99b1273202b2965ac8949c6ab14faa6974669/.github/workflows/release.yml#L16? |
Member
Author
Would have liked some consistency across repos, that's the only one that has the version missing 😞. |
Member
Author
|
Opened containerd/containerd#12583 |
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
update-go-workflow
branch
from
3c6daad to
f82a333
Compare
Member
Author
Has been merged and looks good now: https://github.com/crazy-max/docker-packaging/actions/runs/19741166295/job/56565132263#step:3:70 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #319
tested on my fork: https://github.com/crazy-max/docker-packaging/actions/runs/19737375260
Git diff: https://github.com/crazy-max/docker-packaging/actions/runs/19737457818/job/56552728887#step:4:54
containerd can't be updated because their dockerfile is broken as no
GO_VERSIONdefault is specified: https://github.com/containerd/containerd/blob/fcf99b1273202b2965ac8949c6ab14faa6974669/.github/workflows/release/Dockerfile#L17. @thaJeztah @vvoland @austinvazquez Could we have a default version set in their Dockerfile matching https://github.com/containerd/containerd/blob/fcf99b1273202b2965ac8949c6ab14faa6974669/.github/workflows/release.yml#L16 ?