Remove OneBranchType parameter and use Official type only#3913
Remove OneBranchType parameter and use Official type only#3913cheenamalhotra merged 5 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the governed OneBranch pipeline usage to always extend the Official CrossPlat template (removing runtime-selectable template choice) to satisfy 1ES/PRC compliance requirements.
Changes:
- Removed the
oneBranchTypequeue-time parameter from the affected pipelines. - Hardcoded
extends.templatetov2/OneBranch.Official.CrossPlat.yml@templates. - Simplified SDL configuration by removing conditional logic that only applied to non-official template selection.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/pipelines/dotnet-sqlclient-signing-pipeline.yml | Removes oneBranchType parameter, hardcodes Official template, and deletes non-official-only APIScan override logic. |
| eng/pipelines/akv-official-pipeline.yml | Removes oneBranchType parameter, hardcodes Official template, and makes TSA always enabled (consistent with Official-only usage). |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #3913 +/- ##
===========================================
- Coverage 90.82% 67.56% -23.27%
===========================================
Files 6 263 +257
Lines 316 66170 +65854
===========================================
+ Hits 287 44705 +44418
- Misses 29 21465 +21436
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
We definitely need NonOfficial versions of these pipelines. That is the only way we can run the pipelines from topic branches. Can you create them as part of this PR? |
benrr101
left a comment
There was a problem hiding this comment.
This needs to address nonofficial template builds
paulmedynski
left a comment
There was a problem hiding this comment.
Agree with @benrr101 - Need decidcated NonOfficial pipelines added.
paulmedynski
left a comment
There was a problem hiding this comment.
Should we rename dotnet-sqlclient-signing-pipeline.yml to dotnet-sqlclient-official-pipeline.yml ?
benrr101
left a comment
There was a problem hiding this comment.
Looks to be good - can you link to passing test runs of these pipelines in ADO?
6acf4ba
23c4b58 to
6acf4ba
Compare
mdaigle
left a comment
There was a problem hiding this comment.
We'll need to backport to 6.1 and 6.0
Description
Updates ADO pipelines to use hardcoded OneBranch Official templates instead of parameterized template selection to meet 1ES governance and PRC compliance requirements.
Modified files
Why
The parameterized approach
(OneBranch.${{ parameters.oneBranchType }}.CrossPlat.yml)cannot be statically verified by Production Readiness Check and violates the requirement that production pipelines must always use Official templates.NOTE: If Non-Official pipelines are needed, they should be created as separate pipelines.