-
-
Notifications
You must be signed in to change notification settings - Fork 375
feat(UniverSheet): bump version 10.0.9 #7570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: hernanyoliveira <[email protected]>
Signed-off-by: hernanyoliveira <[email protected]>
|
Thanks for your PR, @hernanyoliveira. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a new Brazilian Portuguese (pt-BR) localization resource JSON file to the project. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- Please double-check that the structure and keys in
localization/pt-BR.jsonmatch exactly with the other existing locale JSON files so that lookups don’t fail at runtime. - Ensure the new
pt-BR.jsonfile uses valid JSON (no trailing commas, correct quoting) and is saved with UTF-8 encoding to avoid issues with special Portuguese characters.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Please double-check that the structure and keys in `localization/pt-BR.json` match exactly with the other existing locale JSON files so that lookups don’t fail at runtime.
- Ensure the new `pt-BR.json` file uses valid JSON (no trailing commas, correct quoting) and is saved with UTF-8 encoding to avoid issues with special Portuguese characters.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7570 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 749 749
Lines 32976 32976
Branches 4580 4580
=========================================
Hits 32976 32976
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # localization/pt-BR.json
Link issues
fixes #7573
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
New Features: