Skip to content

Feature: add Literal for join method "how" argument, modernize typing syntax#345

Merged
evertlammerts merged 2 commits intoduckdb:v1.5-variegatafrom
OutSquareCapital:typing-3.10
Feb 26, 2026
Merged

Feature: add Literal for join method "how" argument, modernize typing syntax#345
evertlammerts merged 2 commits intoduckdb:v1.5-variegatafrom
OutSquareCapital:typing-3.10

Conversation

@OutSquareCapital
Copy link

@OutSquareCapital OutSquareCapital commented Feb 26, 2026

This small PR focus on:

  1. new Literal type for DuckDBPyRelation.join "how" argument, according to the following documentation:
    https://duckdb.org/docs/stable/clients/python/relational_api#join
    This will provide autocomplete and an immediate overview of the supported options.

  2. Replacement of all deprecated 3.9 typing.Union and typing.List usages by their modern counterparts, standardizing this across the file (sometimes it was the old syntax, sometimes the modern one).

I wanted to keep this separated from my next PR who will focus on the Expressions inputs typing, to keep them focused and make review easier (since this one modify lines scattered across the file.)

@evertlammerts evertlammerts merged commit 2fed095 into duckdb:v1.5-variegata Feb 26, 2026
4 of 15 checks passed
@evertlammerts
Copy link
Collaborator

Thanks! I did a quick merge because we're prepping for 1.5 and need ci space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants