Feature: add Literal for join method "how" argument, modernize typing syntax#345
Merged
evertlammerts merged 2 commits intoduckdb:v1.5-variegatafrom Feb 26, 2026
Merged
Conversation
- added Literal for DuckDBPyRelation.join "how" argument possible choices
Collaborator
|
Thanks! I did a quick merge because we're prepping for 1.5 and need ci space. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small PR focus on:
new Literal type for DuckDBPyRelation.join "how" argument, according to the following documentation:
https://duckdb.org/docs/stable/clients/python/relational_api#join
This will provide autocomplete and an immediate overview of the supported options.
Replacement of all deprecated 3.9 typing.Union and typing.List usages by their modern counterparts, standardizing this across the file (sometimes it was the old syntax, sometimes the modern one).
I wanted to keep this separated from my next PR who will focus on the Expressions inputs typing, to keep them focused and make review easier (since this one modify lines scattered across the file.)