A big tidy up of the env

[OliverWoolland]

I've made a start tidying up the config - splitting up .env into multiple files and moving most of the variables out of the main docker compose file

I've a few more changes planned (split up services in compose file, scope env_files to each container) - so no merging yet please

[AndrewThien]

Hi @OliverWoolland,
Sorry for commenting on the draft PR (the PR is great, btw).
Just a head up about we in Nottingham also have the plan to improve the deployment by cleanning up the env vars. (Step 2 in the general plan here https://miro.com/app/board/uXjVGTj0T2U=/?share_link_id=658160857443).

There is an PR on the upstream splitting the docker compose files as well: SwanseaUniversityMedical#73

So do you think it is good to have a discussion about this with the wider team as well? Looking forward to meeting you.
Thanks!

[OliverWoolland]

Hi @AndrewThien thanks for the kind words :) yes I saw you might be doing some work along the same lines! It would be great to chat and figure out how we all work together.

I think we can probably gather most of the technical team for a chat this afternoon if that would work for you? Otherwise we can break out the calendars and figure something out I'm sure

[elichad]

@AndrewThien to add to @OliverWoolland's comment - the Manchester dev team meets at 2-4pm today for our regular technical co-working (over Zoom), the Nottingham devs would be welcome as guests if you happen to be free during part of that time :) It would be an ideal place to have this kind of discussion

[JonaaEva]

Thanks @elichad and @OliverWoolland - happy to join your meeting, though will only be able to stay until 3pm. Could you please forward me the invite to jonaa.eva@nottingham.ac.uk? I will include Thien, Vas, Karthik and Hazel, will be great to connect the teams after our discussion on Tuesday!

[John-Vaughan]

also commented on Nottingham's PR but Posting it here too,
It might be useful to use a compound environment variable
keycloakURL=http://keycloak:8080

SubmissionKeyCloakSettings__MetadataAddress={keycloakURL}/realms/Dare-Control/.well-known/openid-configuration

(this would be in the compose so, It doesn't clog up the environment list)

Then you only need to specify keycloakURL,
since the rest should stay pretty static, I can't think of any reason why anyone would need to change the realm name but, It wouldn't be too hard to modify it to have the realm name as well that you can specify

e.g like so
keycloakURL=http://keycloak:8080
realm=Dare-Control

SubmissionKeyCloakSettings__MetadataAddress={keycloakURL}/realms/{realm}/.well-known/openid-configuration

[John-Vaughan]

I do like the separated environment files for each section I think that's a good change, tho only negative I can think of is when changing something in the deployment just going through all of different environment files just to double Check that there's nothing you need to change.