Fix IllegalArgumentException in PartServiceImpl.addPart when editor area is missing #3673
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
IMHO this is reasonable behavior the PartService |
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Contributor
vogella
force-pushed
the
fix-partservice-npe
branch
from
d677c8e to
0a09322
Compare
If the shared editor area ("org.eclipse.ui.editorss") is not found in the
container, 'area' is null. Passing this null 'area' to
modelService.findElements caused an IllegalArgumentException (via
Assert.isLegal) because the search root cannot be null.
This change adds a null check for 'area'. If 'area' is null, it treats it
as if no shared stacks were found, preventing the exception.
vogella
force-pushed
the
fix-partservice-npe
branch
from
0a09322 to
0da2546
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an IllegalArgumentException in PartServiceImpl.addPart that occurs when the shared editor area ('org.eclipse.ui.editorss') is not found.
The
modelService.findElementsmethod was called with a nullsearchRoot(area) when the editor area could not be located, triggering an assertion failure. This change adds a null check to handle this case gracefully.Verified by running
OpenCloseTestwhich now passes.