Use varargs in FilteredList and AbstractElementListSelectionDialog #3675
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adapts the signature of the following methods to accept a vararg
parameter instead of a plain array:
FilteredList:
- setElements(Object[]) -> setElements(Object...)
- setSelection(int[]) -> setSelection(int...)
- setSelection(Object[]) -> setSelection(Object...)
AbstractElementListSelectionDialog:
- setListElements(Object[]) -> setListElements(Object...)
- setSelection(Object[]) -> setSelection(Object...)
This stops callers from having to explicitly create an array when e.g.
selecting a single element. For example `filteredList.setSelection(new
int[]{0})` can be simplified to `filteredList.setSelection(0)`.
Contributor
Member
|
Thanks, these small and still compatible refinements of Eclipse API are smth I am very happy to see coming. |
iloveeclipse
added a commit
to iloveeclipse/eclipse.platform
that referenced
this pull request
Jan 18, 2026
Compiler warnings: 1) Varargs methods should only override or be overridden by other varargs methods unlike StringVariableSelectionDialog.setListElements(Object[]) and AbstractElementListSelectionDialog.setListElements(Object...) 2) Type IStringVariable[] of the last argument to method setListElements(Object...) doesn't exactly match the vararg parameter type. Cast to Object[] to confirm the non-varargs invocation, or pass individual arguments of type Object for a varargs invocation. Side effect of the signature change in org.eclipse.ui.dialogs.AbstractElementListSelectionDialog.setListElements(Object...) See eclipse-platform/eclipse.platform.ui@647256d / eclipse-platform/eclipse.platform.ui#3675
iloveeclipse
added a commit
to eclipse-platform/eclipse.platform
that referenced
this pull request
Jan 18, 2026
Compiler warnings: 1) Varargs methods should only override or be overridden by other varargs methods unlike StringVariableSelectionDialog.setListElements(Object[]) and AbstractElementListSelectionDialog.setListElements(Object...) 2) Type IStringVariable[] of the last argument to method setListElements(Object...) doesn't exactly match the vararg parameter type. Cast to Object[] to confirm the non-varargs invocation, or pass individual arguments of type Object for a varargs invocation. Side effect of the signature change in org.eclipse.ui.dialogs.AbstractElementListSelectionDialog.setListElements(Object...) See eclipse-platform/eclipse.platform.ui@647256d / eclipse-platform/eclipse.platform.ui#3675
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapts the signature of the following methods to accept a vararg parameter instead of a plain array:
FilteredList:
AbstractElementListSelectionDialog:
This stops callers from having to explicitly create an array when e.g. selecting a single element. For example
filteredList.setSelection(new int[]{0})can be simplified tofilteredList.setSelection(0).