-
Notifications
You must be signed in to change notification settings - Fork 230
Don't do nested resize operations in TableResizeHelper #3677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't do nested resize operations in TableResizeHelper #3677
Conversation
Avoids endless resize operations & UI hangs in case resize listener/handler code itself triggers some OS specific resize events. Fixes eclipse-platform#3676
|
@HeikoKlare : I can't reproduce on Linux, so it looks like it is Windows specific. Could you please check if you can reproduce? |
| public class TableResizeHelper { | ||
|
|
||
| private final TableViewer tableViewer; | ||
| boolean resizeInProgress; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package protected to avoid extra synthetic accessor method being generated
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
HeikoKlare
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't reproduce on Linux, so it looks like it is Windows specific. Could you please check if you can reproduce?
I tried different setups and inputs, but I was not able to reproduce the originally reported issue. Since the report mentions that the issue is sporadic, it seems not so easy to provoke that situation.
Since we quite some changes to control-sizing-related functionality because of the HiDPI functionality on Windows, I also checked if there might be anything involved here (which might have also been resolved recently), but I didn't find anything related.
Given the information we have from the error stack trace, the proposed solution seems fine to avoid a freeze. Since we don't know why the resize triggered itself repeatedly, there is a slight risk of a side effect/regression by the table potentially not reaching a "stable" resized state. But would still be better than running into a freeze.
|
Thanks Heiko. |
Avoids endless resize operations & UI hangs in case resize listener/handler code itself triggers some OS specific resize events.
Fixes #3676