Closed
Conversation
Owner
|
This sounds related to #129. Contrary to the other PR, this one does increase the number of API calls. We also probably need to also fetch the whole message when sending the ENVELOPE? |
Contributor
Author
|
Yeah my bad, I should've tested this a little more.
The PR works fine for my specific setup with offline mail storage - the
slowdown is not noticeable for it to be a problem
However I tried instead logging in directly to the hydroxide imap server
using my MUA and found that trying to fetch mail headers takes a very
long time with this patch applied, rendering it a little impractical :/
…On Wednesday, Jan 06, 2021 at 21:26:14 +1100, Simon Ser ***@***.***> wrote:
This sounds related to #129.
Contrary to the other PR, this one does increase the number of API calls.
We also probably need to also fetch the whole message when sending the
ENVELOPE?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.*
|
Owner
|
Maybe we could check whether we can skip fetching the whole message by looking at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #142
Basically all that needed to be done was in the fetchBodySection method we had to use the headers from the entire fetched message rather than from the one passed to the function.
This is because ProtonMail's API for listing messages (
/messages/<filter>...) does not seem to allow for listing messages with their ReplyTos field included - the field can only be retrieved with the entire message. The message given to fetchBodySection is retrieved using ListMessages, and thus is missing the ReplyTos headerPlease let me know if I did this properly or not 😆