Skip to content

Fix for #142#143

Closed
mikejzx wants to merge 1 commit intoemersion:masterfrom
mikejzx:master
Closed

Fix for #142#143
mikejzx wants to merge 1 commit intoemersion:masterfrom
mikejzx:master

Conversation

@mikejzx
Copy link
Contributor

@mikejzx mikejzx commented Jan 6, 2021

This fixes #142

Basically all that needed to be done was in the fetchBodySection method we had to use the headers from the entire fetched message rather than from the one passed to the function.

This is because ProtonMail's API for listing messages (/messages/<filter>...) does not seem to allow for listing messages with their ReplyTos field included - the field can only be retrieved with the entire message. The message given to fetchBodySection is retrieved using ListMessages, and thus is missing the ReplyTos header

Please let me know if I did this properly or not 😆

@emersion
Copy link
Owner

emersion commented Jan 6, 2021

This sounds related to #129.

Contrary to the other PR, this one does increase the number of API calls.

We also probably need to also fetch the whole message when sending the ENVELOPE?

@mikejzx
Copy link
Contributor Author

mikejzx commented Jan 7, 2021 via email

@mikejzx mikejzx closed this Jan 8, 2021
@emersion
Copy link
Owner

emersion commented Jan 8, 2021

Maybe we could check whether we can skip fetching the whole message by looking at BodyPartName.Fields. Not all email clients set it, though. Some may set it but still require a full fetch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reply-To headers missing

2 participants

Comments