Simplify settings type checking. NFC#26153
Closed
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Closed
Simplify settings type checking. NFC#26153sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
All settings should have known types.
sbc100
force-pushed
the
settings_type_check
branch
from
26a5a80 to
0467c1b
Compare
kripken
reviewed
Jan 23, 2026
| if not expected_type: | ||
| # These settings have a variable type so cannot be easily type checked, or they | ||
| # are legacy settings not declared in settings.js (and therefore not having any type). | ||
| if name in ('USE_PTHREADS', 'EXECUTABLE', 'SUPPORT_LONGJMP', 'PTHREAD_POOL_SIZE', 'SEPARATE_DWARF', 'LTO', 'MODULARIZE'): |
Collaborator
Author
There was a problem hiding this comment.
Because, as mentioned in the comment, its no declared in settings.js. Its deprecated setting.
I have a follow up to add explicit types to all of these.
Member
There was a problem hiding this comment.
thanks, I didn't remember we deprecated it...
kripken
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All settings should have known types.