-
Notifications
You must be signed in to change notification settings - Fork 788
Consolidate CircleCI workflows and optimize test organization #1668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
With that organisation you can have "main" job being the only one required to apply to all jobs that used to be required individually now |
|
I think I would rather have a little more fine-grained info available in the PR without having to click though. For example, its kind of kind of see just the windows jobs failing when you break windows. I know one can always click through.. and I don't feel too strongly about this. @brendandahl @dschuff @juj @kripken what do you folks think? |
|
Thanks for working on this BTW! I really appreciate the improvements. |
|
Also, I do think we want to run the docker build as part of CI (even if we don't run the docker publish). I also think it is nice to have the lint job be super fast so you don't need to wait for it to fail. Its also nice if the lint job can fail but the other jobs still report green (then you know all you need to do is fix the lint errors and your are done). |
a215eaa to
e8ca944
Compare
sbc100
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind splitting this up into 3 changes:
- Add caching to the
lintCI job (how much time does this actually save?) - Extract setup-docker steps.
- Re-organize the OS testing
I will. |
75b2de0 to
d69bb6f
Compare
de07b0d to
117260d
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
sbc100
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe I'd rather keep the bazel jobs separate, so they can pass and fail on their own.
It also increases the parallelism doesn't it?
|
I don't think it changes parallelism as circle ci also execute jobs in parallel . |
Description
Consolidate CircleCI workflows and optimize test organization
Changes
Workflows: 8 → 2
main: Single CI pipeline with dependency chaindocker: Image builds/publishing (unchanged filters)Test organization
Reusable commands
setup-dockercommandbuild-docker-image-x64andpublish-docker-image-x64